Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript types to the next branch #1078

Closed
johno opened this issue May 20, 2020 · 1 comment
Closed

Add TypeScript types to the next branch #1078

johno opened this issue May 20, 2020 · 1 comment
Assignees
@ChristianMurphy
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🦋 type/enhancement This is great to have 💎 v2 Issues related to v2
Milestone
v2

Comments

@johno
Copy link
Member

johno commented May 20, 2020

@ChristianMurphy do you think we can grab the code changes from #811 and apply to the next branch? That's the new working branch for v2 since v2 got so stale 😬😞. I just tried to cherry pick this commit but there have been some monorepo changes so wasn't sure how the dtslint side of things would work.

Would love to get this in there and make sure that you get the code credit!
@johno johno added 🦋 type/enhancement This is great to have 💎 v2 Issues related to v2 👩‍⚕ area/health This affects community 🗄 area/interface This affects the public interface 🔍 status/open labels May 20, 2020
@johno johno added this to the v2 milestone May 20, 2020
@johno johno mentioned this issue May 20, 2020
Closed
25 tasks
@ChristianMurphy
Copy link
Member

Thanks for the ping @johno!
I'll take a look at migrating those over to the next branch.

@ChristianMurphy ChristianMurphy mentioned this issue May 20, 2020
Merged
@johno johno closed this as completed May 20, 2020
@wooorm wooorm added ☂️ area/types This affects typings ⛵️ status/released and removed 👩‍⚕ area/health This affects community 🔍 status/open 🗄 area/interface This affects the public interface labels Jul 23, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianMurphy ChristianMurphy

Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🦋 type/enhancement This is great to have 💎 v2 Issues related to v2
Milestone
v2
Development

No branches or pull requests
3 participants
@wooorm @johno @ChristianMurphy