Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdx 2.3.0 + remark-gfm 4.0.0 breaks tables #2379

Closed
4 tasks done
ky1ejs opened this issue Oct 22, 2023 · 6 comments
Closed
4 tasks done

mdx 2.3.0 + remark-gfm 4.0.0 breaks tables #2379

ky1ejs opened this issue Oct 22, 2023 · 6 comments
Labels
💪 phase/solved Post is done

Comments

@ky1ejs
Copy link
Contributor

ky1ejs commented Oct 22, 2023

Initial checklist

Affected packages and versions

2.3.0

Link to runnable example

No response

Steps to reproduce

  1. Check out Bump remark-gfm from 3.0.1 to 4.0.0 ky1ejs/kylejs-site#86
  2. Run npm run build
  3. See error relating to GFM table

Expected behavior

Build should complete successfully

Actual behavior

TypeError: Cannot read properties of undefined (reading 'inTable')

268693986-e320c477-446a-4a47-9b16-d01825fccfac

Runtime

Node v18

Package manager

npm v9

OS

macOS

Build and bundle tools

Next.js

@ky1ejs
Copy link
Contributor Author

ky1ejs commented Oct 22, 2023

I wanted to report this since I didn't see an issue tracking this problem on this repo yet.

According to this remark-gfm issue, many packages in the Markdown JS/TS ecosystem are still updating to latest models/packages since a major release recently (circa August 2023).

In the issue linked above, the maintainer mentions that MDX should be making its way to be up to date with the latest changes.

I'd be happy to help out with this, be would be helpful to get an intro to the work with an existing contributor (and, for that matter, a status check of whether y'all are already aware/working on this :) ).

p.s. thanks so much for your work on this project!

@wooorm
Copy link
Member

wooorm commented Oct 22, 2023

All the packages are done except for MDX (and remark-lint). Wait a day or two for MDX. One feature rest docs. Use the previous remark-gfm for now.

@ky1ejs ky1ejs changed the title mdx 2.3.0 + remark-gfm 4.0.0 breaks tablesd mdx 2.3.0 + remark-gfm 4.0.0 breaks tables Oct 22, 2023
@wooorm
Copy link
Member

wooorm commented Oct 24, 2023

v3 is out!

@wooorm wooorm closed this as completed Oct 24, 2023
@wooorm wooorm added the 💪 phase/solved Post is done label Oct 24, 2023
@muditjuneja
Copy link

muditjuneja commented Feb 7, 2024

I am using these 2 -
"@mdx-js/mdx": "^3.0.0", "@mdx-js/react": "^3.0.0"

along with "remark-gfm": "^4.0.0" and this still gives me this error.
I am using gatsby with "gatsby-plugin-mdx": "^5.13.1",

But when I downgrade remark-gfm to 3.0.1, it works. What could be causing this as everywhere I am seeing that this has been fixed now.

@ChristianMurphy
Copy link
Member

@muditjuneja this is a bug in gatsby-plugin-mdx, Gatsby does not support MDX 3 yet.
See gatsbyjs/gatsby#36406 and gatsbyjs/gatsby#38789

@muditjuneja
Copy link

Thank you @ChristianMurphy ++++ for these links. I will read more into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

No branches or pull requests

4 participants