Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash if file is not in the TypeScript project #281

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

remcohaszing
Copy link
Member

This affects:

  • If no tsconfig.json exists.
  • If tsconfig.json specifies includes, but doesn’t include the MDX file.
  • If tsconfig.json specifies excludes and excludes the MDX file.
  • If a new file is created.
  • If a file is renamed.

Closes #269

This affects:
- If no `tsconfig.json` exists.
- If `tsconfig.json` specifies `includes`, but doesn’t include the MDX
  file.
- If `tsconfig.json` specifies `excludes` and excludes the MDX file.
- If a new file is created.
- If a file is renamed.

Closes #269
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 👍 phase/yes Post is accepted and can be worked on labels Jan 22, 2023
@remcohaszing remcohaszing requested a review from a team January 22, 2023 12:48
@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2023

🦋 Changeset detected

Latest commit: d70c486

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-mdx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remcohaszing remcohaszing merged commit b0bc3a1 into main Jan 22, 2023
@remcohaszing remcohaszing deleted the fix-script-filenames branch January 22, 2023 20:14
@remcohaszing
Copy link
Member Author

This has been released in v1.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

[Experimental intellisense] "Could not find source file"
2 participants