Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When setting #define ASYNC_TCP_SSL_ENABLED 1 build fails #131

Closed
jeroenst opened this issue Oct 31, 2019 · 6 comments
Closed

When setting #define ASYNC_TCP_SSL_ENABLED 1 build fails #131

jeroenst opened this issue Oct 31, 2019 · 6 comments
Labels

Comments

@jeroenst
Copy link

When I want to use the SSL feature, and enable #define ASYNC_TCP_SSL_ENABLED 1 in async_config.h I get the following build error:

/home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp: In member function 'err_t AsyncServer::_poll(tcp_pcb*)':
/home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp:1324:31: error: no matching function for call to 'AsyncClient::_recv(tcp_pcb*&, pbuf*&, int)'
c->_recv(pcb, p->pb, 0);
^
/home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp:1324:31: note: candidate is:
/home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp:565:6: note: void AsyncClient::_recv(std::shared_ptr&, tcp_pcb*, pbuf*, err_t)
void AsyncClient::_recv(std::shared_ptr& errorTracker, tcp_pcb* pcb, pbuf* pb, err_t err) {
^
/home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp:565:6: note: candidate expects 4 arguments, 3 provided

@mhightower83
Copy link
Contributor

mhightower83 commented Oct 31, 2019

@jeroenst - Sorry, I missed that build option in my original testing of my now merged PR.
This new PR #129 (comment) should resolve your problem plus one more corner case that I found.
If you download the four files that changed and recompile, it should work.
Please post back your result so others will know if it worked.

@stale
Copy link

stale bot commented Dec 30, 2019

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 30, 2019
@shprota
Copy link

shprota commented Dec 30, 2019

The fix has worked for me. Please close the issue.

@stale
Copy link

stale bot commented Dec 30, 2019

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

@stale stale bot removed the stale label Dec 30, 2019
@stale
Copy link

stale bot commented Feb 28, 2020

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 28, 2020
@stale
Copy link

stale bot commented Mar 13, 2020

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants