Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.0.0b] [Task] - Public Group Exploration #1326

Closed
3 tasks done
hay-kot opened this issue May 31, 2022 · 14 comments · Fixed by #2525
Closed
3 tasks done

[v1.0.0b] [Task] - Public Group Exploration #1326

hay-kot opened this issue May 31, 2022 · 14 comments · Fixed by #2525
Labels
feature task General Task that needs to be completed v1 Version 1 Issue/PR

Comments

@hay-kot
Copy link
Collaborator

hay-kot commented May 31, 2022

What is the problem this task addresses?

Currently sharing a recipe requires a manual process to share. Mealie should provide a way for groups to share their recipes by default.

Proposed/Possible Solution(s)?

Group Pages

The foundational page relating to sharing Recipes and Cookbooks. It should show a link to browse a groups entire public recipe collection, as well as their cookbooks. In the future it may also support browsing by categories, tools, and

Cookbooks

Allow cookbooks to be set to public and shareable via a link or discoverable on group pages

Public Recipes

Allow public recipes to be browsed by group from non members.


Checklist

@hay-kot hay-kot added task General Task that needs to be completed v1 Version 1 Issue/PR labels May 31, 2022
@hay-kot hay-kot modified the milestones: v1.0.0beta-4, v1.0.0beta-5 May 31, 2022
@l0el
Copy link

l0el commented Jul 25, 2022

Curious, any updates on this? The fact that you can only generate temporary sharable links (that are also ugly) is the only thing holding me back from using this. Would be super nice to have public-by-default as an option, with WordPress style pretty links.

@hay-kot
Copy link
Collaborator Author

hay-kot commented Aug 4, 2022

My timeline got pushed back because of some summer vacation stuff. Currently hoping to get this rolled into the next beta at the end of the month. It may be a partial implementation, we'll see how far I get.

@l0el
Copy link

l0el commented Aug 9, 2022

Oh awesome @hay-kot !! Might sound dumb, but sharable, pretty links is a make or break feature for a food blogger :)

@gleeds
Copy link

gleeds commented Aug 9, 2022

I agree. I've been using mealie to build a collection of recipes to try, then the ones that turn out well we share links to our friends and family, but we don't want to make them create accounts, so I'm stuck on 0.5.6 until this feature get's re-added. While I typically share a specific recipe link, I still want browsing everything to be available.

@NHellFire
Copy link

Any progress on this?
This not being added yet makes 1.0 worse for me than 0.5, but as 1.0 is performing better, I've just removed the group checks for my use case (shared recipes, separate meal plans). Unfortunately that's about the limit to my understanding of the code, I have no idea how I'd properly check the public setting.

@Naticus
Copy link

Naticus commented Jan 18, 2023

Any progress on this? This not being added yet makes 1.0 worse for me than 0.5, but as 1.0 is performing better, I've just removed the group checks for my use case (shared recipes, separate meal plans). Unfortunately that's about the limit to my understanding of the code, I have no idea how I'd properly check the public setting.

How did you go about removing the group checks? I think that might be a good solution for me and my friend group right now so I can maintain separate meal plans, shopping lists, etc.

@NHellFire
Copy link

NHellFire commented Jan 24, 2023

Any progress on this? This not being added yet makes 1.0 worse for me than 0.5, but as 1.0 is performing better, I've just removed the group checks for my use case (shared recipes, separate meal plans). Unfortunately that's about the limit to my understanding of the code, I have no idea how I'd properly check the public setting.

How did you go about removing the group checks? I think that might be a good solution for me and my friend group right now so I can maintain separate meal plans, shopping lists, etc.

Attached the patch I'm using. If any users have categories with the same names, they'll need to first rename or delete them (it will error on duplicates). Might be some unneeded changes in that, I found some more problems with mealplans that I fixed today.

mealie-no-group-checks.patch

For docker-compose, you can add this to your volumes (on the api service) to replace the patched files:

      - ./mealie-git/mealie/repos/repository_recipes.py:/app/mealie/repos/repository_recipes.py
      - ./mealie-git/mealie/routes/recipe/recipe_crud_routes.py:/app/mealie/routes/recipe/recipe_crud_routes.py
      - ./mealie-git/mealie/routes/groups/controller_cookbooks.py:/app/mealie/routes/groups/controller_cookbooks.py
      - ./mealie-git/mealie/routes/groups/controller_mealplan.py:/app/mealie/routes/groups/controller_mealplan.py
      - ./mealie-git/mealie/routes/organizers/controller_categories.py:/app/mealie/routes/organizers/controller_categories.py
      - ./mealie-git/mealie/routes/organizers/controller_tags.py:/app/mealie/routes/organizers/controller_tags.py

@Marcbacca
Copy link

Has there been any updates on this? I am also stuck on 0.5.6 due to the new betas requiring a login for read access. My setup is behind Authentik, so the read only option with no mealie authentication needed is perfect, thanks.

@hay-kot
Copy link
Collaborator Author

hay-kot commented Mar 3, 2023

Has there been any updates on this? I am also stuck on 0.5.6 due to the new betas requiring a login for read access. My setup is behind Authentik, so the read only option with no mealie authentication needed is perfect, thanks.

No, it's been deprioritized because, 1) I don't use the feature, 2) it requires extensive reworking on nearly every component related to recipe views. 3) No other contributors seem super interested in taking on the work here.

Happy to help someone get started on it if they're interested in adding the feature, but I'm more focused on getting v1 to stable than taking on this feature.

@DrSpaldo
Copy link

I am also very interested in this one. It would be good to be able to give out my recipes to family without them having to use a login

@LP0101
Copy link

LP0101 commented Mar 18, 2023

+1 for this too!

My family and I all started using mealie recently and we love it. We're split into different groups by household, but we'd love to be able to get recipes from other groups

@hay-kot
Copy link
Collaborator Author

hay-kot commented Mar 21, 2023

It's pretty clear there's lot's of interest in this feature. If you're interested in taking on the feature work for this please let me know.

@michael-genson
Copy link
Collaborator

michael-genson commented Aug 27, 2023

#2525 covers most all of this

@michael-genson
Copy link
Collaborator

you can only generate temporary sharable links (that are also ugly)

FYI this has been addressed recently: #2482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature task General Task that needs to be completed v1 Version 1 Issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants