fix: Images Using Wrong Content Type #4441
Open
+4
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmintey
reviewed
Oct 24, 2024
docs/docs/documentation/getting-started/installation/security.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
When we used to use Caddy with the split containers, it used to do its own magic to serve the correct content type for images. Since we ditched the split container design we (probably inadvertently) switched to the "dev" media routes which don't specify content type.
This PR removes references to Caddy, unhides the "dev" media routes (because they actually get used), and explicitly adds the content type to said routes.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3599
Fixes #4144
Testing
(fill-in or delete this section)
Tested locally. I struggled to test #3599 locally, but the error raised (before this fix) makes me pretty confident this is the issue:
ERROR Content-Type: text/plain; charset=utf-8 is not an image