Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a recipe with time information #689

Closed
Cebrain opened this issue Sep 22, 2021 · 2 comments
Closed

Importing a recipe with time information #689

Cebrain opened this issue Sep 22, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Cebrain
Copy link

Cebrain commented Sep 22, 2021

Describe the bug

I want to import a recipe and it works fine but the time factors are not importet.

Steps To Reproduce
Please be specific!

  1. Go to 'Import Recipe'
  2. Importet Url 'https://www.chefkoch.de/rezepte/1616691268862802/Zucchini-Lasagne.html'

Expected behavior

All times will be importet
Total Time
Prep Time
Cook Time

Actual Behavior

No information about time will be importet

Device Information (please complete the following information):

  • OS: Windows 10
  • Deployment: Docker
  • Browser: Firefox latest version
  • Version: 0.5.2
@Cebrain Cebrain added the bug Something isn't working label Sep 22, 2021
@hay-kot hay-kot added the good first issue Good for newcomers label Sep 23, 2021
@cadamswaite
Copy link

The issue was that the times coming from the recipe scraper were not in the expected format
scraper.schema.data.get('prepTime')='P0DT0H40M'
scraper.schema.data.get('totalTime')='P0DT1H20M'
scraper.schema.data.get('performTime')=None

This is partially fixed by PR #733 (Total time + Prep time are now imported)
Note the scraper did not manage to capture the perform (cook) time for the recipe - so it could not be imported.
If it's important, the scraper would need to be improved for this website

@cadamswaite
Copy link

When playing around with the recipe debugger in #736, I found the cook time for this recipe was in the schema - just as cookTime instead of performTime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants