Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

Commit 482c38c

Browse files
simisonlirantal
authored andcommitted
feat(travis): start testing against Node.js 8 and other CI improvements (#1785)
* Test against Node.js 8 Configure Travis CI test against Node.js 8 and allow failures. Node.js 8 release notes: https://nodejs.org/en/blog/release/v8.0.0/ * Updates to TravisCI * Refactor picking debug argument for different Node.js versions
1 parent 4321744 commit 482c38c

File tree

3 files changed

+16
-22
lines changed

3 files changed

+16
-22
lines changed

.travis.yml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ sudo: false
44
node_js:
55
- '6.10'
66
- '7'
7-
#matrix:
8-
# allow_failures:
9-
# - node_js: 7
7+
- '8'
8+
matrix:
9+
fast_finish: true
10+
allow_failures:
11+
- node_js: '8'
1012
os:
1113
- linux
1214
- centos
@@ -27,11 +29,11 @@ addons:
2729
- gcc-4.8
2830
- clang
2931
before_install:
30-
- npm i nsp -g
31-
- npm i snyk -g
32+
- npm install nsp -g
33+
- npm install snyk -g
3234
- npm install protractor
33-
- "export DISPLAY=:99.0"
34-
- "sh -e /etc/init.d/xvfb start"
35+
- 'export DISPLAY=:99.0'
36+
- 'sh -e /etc/init.d/xvfb start'
3537
- 'node_modules/protractor/bin/webdriver-manager update --standalone --firefox'
3638
- 'node_modules/protractor/bin/webdriver-manager start 2>&1 &'
3739
- sleep 3

gulpfile.js

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ var _ = require('lodash'),
2525
webdriver_update = require('gulp-protractor').webdriver_update,
2626
webdriver_standalone = require('gulp-protractor').webdriver_standalone,
2727
del = require('del'),
28-
KarmaServer = require('karma').Server;
28+
KarmaServer = require('karma').Server,
29+
semver = require('semver');
2930

3031
// Local settings
3132
var changedTestFiles = [];
@@ -48,18 +49,8 @@ gulp.task('env:prod', function () {
4849
// Nodemon task
4950
gulp.task('nodemon', function () {
5051

51-
var nodeVersions = process.versions;
52-
var debugArgument = '--debug';
53-
switch (nodeVersions.node.substr(0, 1)) {
54-
case '4':
55-
case '5':
56-
case '6':
57-
debugArgument = '--debug';
58-
break;
59-
case '7':
60-
debugArgument = '--inspect';
61-
break;
62-
}
52+
// Node.js v7 and newer use different debug argument
53+
var debugArgument = semver.satisfies(process.versions.node, '>=7.0.0') ? '--inspect' : '--debug';
6354

6455
return plugins.nodemon({
6556
script: 'server.js',

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,22 @@
1515
"npm": ">=3.10.8"
1616
},
1717
"scripts": {
18-
"update": "npm update && npm prune && bower install --allow-root && bower prune --allow-root",
18+
"update": "npm update && npm prune && npm run bower",
1919
"clean": "rm -rf node_modules/ public/lib/",
2020
"reinstall": "npm cache clean && npm run clean && npm install",
2121
"start": "gulp",
2222
"start:prod": "gulp prod",
2323
"start:debug": "node-debug --web-host 0.0.0.0 server.js & gulp debug",
2424
"gulp": "gulp",
25+
"bower": "bower install --allow-root && bower prune --allow-root",
2526
"lint": "gulp lint",
2627
"test": "gulp test",
2728
"test:server": "gulp test:server",
2829
"test:server:watch": "gulp test:server:watch",
2930
"test:client": "gulp test:client",
3031
"test:e2e": "gulp test:e2e",
3132
"test:coverage": "gulp test:coverage",
32-
"postinstall": "bower install --allow-root && bower prune --allow-root",
33+
"postinstall": "npm run bower",
3334
"generate-ssl-certs": "scripts/generate-ssl-certs.sh"
3435
},
3536
"dependencies": {

0 commit comments

Comments
 (0)