Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Commit

Permalink
fix(build): E2E coverage broken on Travis CI (#1805)
Browse files Browse the repository at this point in the history
Fixes an issue with the Travis CI builds failing at the E2E tests due to
an apparent issue with the Mozilla Gecko web-driver used with Selenium.

1) Upgrades `gulp-protractor` to ensure Protractor v5> is used.
2) Removes `--firefox` option from the Travis CI Selenium
`webdriver-manager update` step.
3) Changes Protractor config to use Chrome instead of Firefox.
  • Loading branch information
mleanos authored and lirantal committed Jul 1, 2017
1 parent 0cbdbda commit e3df83e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ before_install:
- npm install protractor
- 'export DISPLAY=:99.0'
- 'sh -e /etc/init.d/xvfb start'
- 'node_modules/protractor/bin/webdriver-manager update --standalone --firefox'
- 'node_modules/protractor/bin/webdriver-manager update --standalone'
- 'node_modules/protractor/bin/webdriver-manager start 2>&1 &'
- sleep 3
#before_script:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"gulp-mocha": "~3.0.1",
"gulp-ng-annotate": "~2.0.0",
"gulp-nodemon": "~2.2.1",
"gulp-protractor": "^3.0.0",
"gulp-protractor": "^4.0.0",
"gulp-refresh": "~1.1.0",
"gulp-rename": "~1.2.2",
"gulp-rev": "^7.1.2",
Expand Down
7 changes: 6 additions & 1 deletion protractor.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ var config = {

if (process.env.TRAVIS) {
config.capabilities = {
browserName: 'firefox'
// Without this setting, Travis CI would default
// to using Chrome anyway.
// NOTE: Firefox is currently not working with
// the Travis CI builds. For more info see:
// https://github.com/meanjs/mean/pull/1805
browserName: 'chrome'
};
}

Expand Down

0 comments on commit e3df83e

Please sign in to comment.