Fixing errors style

Author: amoshaviv

app/controllers/users.js

@@ -51,12 +51,23 @@ exports.session = function(req, res) {
  */
 exports.create = function(req, res) {
     var user = new User(req.body);
+    var message = null;
 
     user.provider = 'local';
     user.save(function(err) {
         if (err) {
+            console.log(err);
+            switch(err.code){
+                case 11000:
+                case 11001:
+                    message = 'Username already exists';
+                    break;
+                default: 
+                    message = 'Please fill all the required fields';
+            }
+
             return res.render('users/signup', {
-                errors: err.errors,
+                message: message,
                 user: user
             });
         }

app/models/user.js

@@ -18,8 +18,8 @@ var UserSchema = new Schema({
         type: String,
         unique: true
     },
-    provider: String,
     hashed_password: String,
+    provider: String,
     salt: String,
     facebook: {},
     twitter: {},
@@ -116,8 +116,7 @@ UserSchema.methods = {
      * @api public
      */
     encryptPassword: function(password) {
-        if (!password) return '';
-        if (!this.salt) return '';
+        if (!password || !this.salt) return '';
         salt = new Buffer(this.salt, 'base64');
         return crypto.pbkdf2Sync(password, salt, 10000, 64).toString('base64');
     }

app/views/users/auth.jade

@@ -12,4 +12,8 @@ block content
       a(href="/auth/google")
         img(src="/img/icons/google.png")
     .span6
+      if message && message.length
+        .fade.in.alert.alert-error
+          button.close(type="button", data-dismiss="alert") ×
+          strong #{message}
       block auth

app/views/users/signin.jade

@@ -1,15 +1,6 @@
 extends auth
 
 block auth
-  if message.length > 0
-    .fade.in.alert.alert-block.alert-error
-      p #{message}
-      a.close(data-dismiss="alert", href="javascript:void(0)") x
-      ul
-        each error in errors
-          li= error
-
-
   form.signin.form-horizontal(action="/users/session", method="post")
     .control-group
       label.control-label(for='email') Email

config/routes.js

@@ -4,17 +4,17 @@ module.exports = function(app, passport, auth) {
     app.get('/signin', users.signin);
     app.get('/signup', users.signup);
     app.get('/signout', users.signout);
+    app.get('/users/me', users.me);
 
     //Setting up the users api
     app.post('/users', users.create);
 
+    //Setting the local strategy route
     app.post('/users/session', passport.authenticate('local', {
         failureRedirect: '/signin',
-        failureFlash: 'Invalid email or password.'
+        failureFlash: true
     }), users.session);
 
-    app.get('/users/me', users.me);
-
     //Setting the facebook oauth routes
     app.get('/auth/facebook', passport.authenticate('facebook', {
         scope: ['email', 'user_about_me'],