Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Lint error when building assets #1360

Open
fauria opened this issue Jun 10, 2016 · 7 comments
Open

Lint error when building assets #1360

fauria opened this issue Jun 10, 2016 · 7 comments

Comments

@fauria
Copy link
Contributor

fauria commented Jun 10, 2016

When running gulp build or grunt build, trailing commas are added to config/assets/production.js resulting in:

...
Running "eslint:target" (eslint) task

/Directory/config/assets/production.js
  11:65  error  Unexpected trailing comma  comma-dangle
  28:60  error  Unexpected trailing comma  comma-dangle

✖ 2 problems (2 errors, 0 warnings)

Warning: Task "eslint:target" failed. Use --force to continue.

Edit: Only gulp build adds those commas, grunt buildworks fine.

@lirantal lirantal assigned lirantal and unassigned lirantal Jun 16, 2016
@shanavas786
Copy link
Contributor

Its because grunt build just use the default assets configurations and doesn't create one based on bower.json (No wiredep task. Porbably a bug :) ).

I have worked on removing trailing comma using gulp-trailing-comma. But the npm package is not up-to-date friskfly/gulp-trailing-comma#2. I will create a PR once it is updated.

@lirantal lirantal self-assigned this Jun 16, 2016
@ilanbiala
Copy link
Member

Is there still work that needs to be done here?

@shanavas786
Copy link
Contributor

shanavas786 commented Jul 16, 2016

Since there is no update on friskfly/gulp-trailing-comma#2 , i have created a package and plugins for gulp and grunt for removing trailing commas.

@ilanbiala
Copy link
Member

@lirantal can you take a look at the PR?

@lirantal
Copy link
Member

Re-opening this issue as it is still relevant, waiting for @shanavas786 PR.

@shanavas786
Copy link
Contributor

I have started #1412 .
@lirantal Please have a look.

@mleanos
Copy link
Member

mleanos commented Oct 15, 2016

@shanavas786 @lirantal Moving to backlog since there hasn't been a successful PR that solves this issue.

@mleanos mleanos modified the milestones: Backlog, 0.5.0 Oct 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants