This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(core): fix twitter meta tags #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the Twitter meta tags are outdated and this PR fixes them. Taking into account the current MEAN.js tags and the Twitter docs, the most similar feature I found is the Twitter Summary Card (https://dev.twitter.com/cards/types/summary).
|
Thanks Pedro. Could you by any chance also review the other social network logins? They might also need an update. |
|
I took a look at Facebook docs and the Facebook meta tags seem to be fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(core): fix twitter meta tags
I believe the Twitter meta tags are outdated and this PR fixes them.
Taking into account the current MEAN.js tags and the Twitter docs, the most similar feature I found
is the Twitter Summary Card (https://dev.twitter.com/cards/types/summary), which requires 2 tags that currently do not exist (twitter:card and twitter:site) and there's another one already implemented in MEAN.js which is not referenced in Twitter docs (twitter:url).