Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Documentation: Menu::addMenuItem incorrect #251

Closed
NeverOddOrEven opened this issue Nov 4, 2014 · 6 comments
Closed

Documentation: Menu::addMenuItem incorrect #251

NeverOddOrEven opened this issue Nov 4, 2014 · 6 comments

Comments

@NeverOddOrEven
Copy link
Contributor

The parameter list specified in the docs does not reflect the source code.

In the code:

this.addMenuItem = function(menuId, menuItemTitle, menuItemURL, menuItemType, menuItemUIRoute, isPublic, roles, position)

In the docs:

this.addMenuItem = function(menuId, menuItemTitle, menuItemURL, menuItemUIRoute, isPublic, roles, position)
@amoshaviv
Copy link
Contributor

Hey alex can we change this in the gh-pages branch and close this issue?

@NeverOddOrEven
Copy link
Contributor Author

Should be fixed in this pull request.

@NeverOddOrEven
Copy link
Contributor Author

This needs review by community before merging. Can we get a label to that effect?

@ilanbiala
Copy link
Member

What are we +1? Isn't this something that is inconsistent?

@NeverOddOrEven
Copy link
Contributor Author

Went ahead and merged since it was a minor docs update. @ilanbiala just trying to ensure quality and that i'm not too tired when making these updates.

@ilanbiala
Copy link
Member

I got you. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants