Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

User OAuth missing tests? #273

Closed
ilanbiala opened this issue Nov 21, 2014 · 6 comments
Closed

User OAuth missing tests? #273

ilanbiala opened this issue Nov 21, 2014 · 6 comments

Comments

@ilanbiala
Copy link
Member

It seems like the User module is only being tested against local strategies, but the user can also be created through OAuth, which should probably be tested too, no?

@ilanbiala
Copy link
Member Author

Any thoughts on how to do this? I can' think of any way to independently test the controller logic.

@sielay
Copy link

sielay commented Dec 11, 2014

Controllers may need small refactor. I am looking in that at the moment, as I found some lacks in the flow.
#288

@ilanbiala
Copy link
Member Author

@amoshaviv tests are probably more important than features, because I want to know that everything is always working. How can we test this?

@androidfred
Copy link
Contributor

In this case, the issue referred to by sielay is arguably a bug and not a feature. @ilanbiala would you mean detaling more specifically what parts of the code you would like tests for?

@ilanbiala
Copy link
Member Author

Oath link and callbacks and logic.

@lirantal
Copy link
Member

Closing an old thread.
@ilanbiala @androidfred @sielay you're welcome to propose a PR if this issue is still relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants