-
Notifications
You must be signed in to change notification settings - Fork 2k
2 different views with forms for creating and updating articles - bad practice #336
Comments
Are you saying that say if I add a new field to the articles, say a keywords field, then I would have to separately add that both into the create view and the update view? If that's the case, I agree with you, and I wrote a blogpost about a possible way to do that, if you end up working on the PR and want ideas. |
Yes, that's exactly what I want to say. Could you post the link you your blogpost? I already have my implementation, but it would be nice to check your ideas |
I agree, this violates DRY and is bad practice, would be great if you could fix it! |
just commited pull request |
My post was about using a directive and controlling the method through an attribute, but this seems much neater! |
Seems we've already done some refactoring there on the articles module. @ramusus @JuanCaicedo welcome to comment and add anything else if you'd like. |
I suppose it would be better to join them into one view with one article form. Otherwise there is violatation of DRY principe. And it's much more complicated handle of the same html form in 2 different places
I can make PR If you agree with my point of view.
The text was updated successfully, but these errors were encountered: