Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Node-pre-gyp package? #938

Closed
ilanbiala opened this issue Sep 26, 2015 · 8 comments
Closed

Node-pre-gyp package? #938

ilanbiala opened this issue Sep 26, 2015 · 8 comments
Assignees
Milestone

Comments

@ilanbiala
Copy link
Member

@lirantal Where are we using the node-pre-gyp package?

@lirantal
Copy link
Member

@ilanbiala maybe you should ask Cody:

5d5d1b7b (Cody Daig       2015-07-17 01:09:08 -0700  50)     "node-pre-gyp": "0.6.4",

@ilanbiala
Copy link
Member Author

@codydaig do you know what the node-pre-gyp package is doing? I don't see it being required anywhere.

@simison
Copy link
Member

simison commented Sep 27, 2015

Running npm ls shows it being required in a couple of places, notably:

├─┬ connect-mongo@0.8.1
│ ├─┬ debug@2.2.0
│ │ └── ms@0.7.1
│ ├── depd@1.0.1
│ └─┬ mongodb@2.0.31
│   ├─┬ mongodb-core@1.1.26
│   │ ├─┬ bson@0.3.2
│   │ │ └─┬ bson-ext@0.1.6
│   │ │   ├── nan@1.8.4
│   │ │   └─┬ node-pre-gyp@0.6.4

@ilanbiala
Copy link
Member Author

@simison that's fine that it is depended on, but there is no reason to have it as a top level dependency of our app.

@codydaig
Copy link
Member

@ilanbiala Sorry for the delay. That came a PR I did to get rid of the npm warnings for the future upgrade of npm 3. It had something to do with dependency resolution.

@ilanbiala
Copy link
Member Author

It's not used anywhere though, do you remember the PR?

@lirantal
Copy link
Member

@ilanbiala just submit a PR to remove it and we'll see if it fails or not in the CI :)

@ilanbiala
Copy link
Member Author

#1001

@ilanbiala ilanbiala added this to the 0.4.2 milestone Oct 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants