Update multer middleware in config/lib/express.js

[gustavodemari]

Hi guys,

The multer library has changed, and also they've changed the way of using multer as a middleware in express.

Old way:

var express = require('express')
var multer  = require('multer')

var app = express()
app.use(multer({ dest: './uploads/'}))

New way:

var express = require('express')
var multer  = require('multer')
var upload = multer({ dest: 'uploads/' })

var app = express()

app.post('/profile', upload.single('avatar'), function (req, res, next) {
  // req.file is the `avatar` file
  // req.body will hold the text fields, if there were any
})

app.post('/photos/upload', upload.array('photos', 12), function (req, res, next) {
  // req.files is array of `photos` files
  // req.body will contain the text fields, if there were any
})

var cpUpload = upload.fields([{ name: 'avatar', maxCount: 1 }, { name: 'gallery', maxCount: 8 }])
app.post('/cool-profile', cpUpload, function (req, res, next) {
  // req.files is an object (String -> Array) where fieldname is the key, and the value is array of files
  //
  // e.g.
  //  req.files['avatar'][0] -> File
  //  req.files['gallery'] -> Array
  //
  // req.body will contain the text fields, if there were any
})

As you can see below, we are using the old way of usage in the config/lib/express.js#L92-L97

  // Add multipart handling middleware
  app.use(multer({
    dest: './uploads/',
    inMemory: true
  }));
};

At the same time, we are using the parameter inMemory:true, that can lead our apps to run out of memory as pointed out here https://github.com/expressjs/multer#memorystorage

Also, I tried to remove the parameter inMemory (it's the same to set inMemory:false) and had an issue changing the profile image, because our controller uses the buffer (req.files.file.buffer) to change the profile picture.

So, my suggestion is to update the way we use multer, and maybe, remove the parameter inMemory:true and adjust the controller to don't use req.files.file.buffer

[codydaig]

@gustavodemari Submit a PR!

[ezerw]

Creating "uploads" folder in "/modules/users/client/img/profile" works for me (multer old way).