This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fixes db deployment issue on heroku. production db value needs to be set... #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set in production.js and removed db variable from all.js.
|
Hi @jshultz this is a a good observation but we currently try to keep the config files clean from host specific properties. Definitely a problem though with the inclusion of Heroku's Mongo URIs and overriding them in the production file, will solve it soon. |
amoshaviv
added a commit
that referenced
this pull request
Mar 27, 2014
fixes db deployment issue on heroku. production db value needs to be set...
|
I merged this in and tweaked it a bit, thanks |
Closed
lirantal
pushed a commit
that referenced
this pull request
Jul 15, 2015
Merge Gh pages jekyll Branch
Closed
pdfowler
pushed a commit
to pdfowler/mean
that referenced
this pull request
Jan 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes db deployment issue on heroku. production db value needs to be set in production.js and removed db variable from all.js.