Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

on "haven't" "don't" #12

Open
vefish opened this issue Oct 11, 2018 · 4 comments
Open

on "haven't" "don't" #12

vefish opened this issue Oct 11, 2018 · 4 comments

Comments

@vefish
Copy link

vefish commented Oct 11, 2018

Amazing work! THX first.

It appears WD mark them not the whole word with word like "haven't " or "don't", WD only mark "haven" or "don" as new words and ignore "'t", when I set not highlighting 15% words to 0% since I import known list by myself.

Could WD mark them as whole when turning off that most common list on such situation?
Could I know how to empty vocabulary after exporting it, empty it, then import a new one?

Thank you again.

@mechatroner
Copy link
Owner

Hello!
Thank you for the feedback!
I think WD highlights "haven" and "don" because

  1. These are real words, see https://en.wiktionary.org/wiki/haven and https://en.wiktionary.org/wiki/don
  2. Tokenization method that WD uses in realtime during browsing is also pretty rudimentary so it also splits "haven't" and "don't" into "haven", "t" and "don", "t"

Unfortunately I don't have time now to fix this, and it may not be trivial.
You can try to add "haven" and "don" to your list to stop highlighting them.

When you export a new list it gets merged with the old one, so new words are added while keeping the old ones. To entirely remove the previous list you can try to reinstall WD

@vefish
Copy link
Author

vefish commented Oct 12, 2018

Thank you for patient explanation!
May be it will be fixed when u r convenient sometime.
Again, I really appreciate your wonderful work, thank u!

Today I met two new words not highlighted by WD, the first one I forgot, the second is "Daytona", I checked it's not in my vocab exported.

@mechatroner
Copy link
Owner

You are welcome!
WD highlights words from this list: https://raw.githubusercontent.com/mechatroner/aided_reading/master/words_discoverer_chrome/eng_dict.txt
So if Daytona is not there it won't be highlighted.

@vefish
Copy link
Author

vefish commented Oct 16, 2018

Advice: Could words not in eng_dict.txt be highlighted in a way like other color or so someday?
Then won't miss new word.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants