Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent stack trace grow in certain scenarios #42

Open
medikoo opened this issue Dec 22, 2015 · 1 comment
Open

Prevent stack trace grow in certain scenarios #42

medikoo opened this issue Dec 22, 2015 · 1 comment
Assignees
@medikoo
Labels
bug

Comments

@medikoo
Copy link
Owner

medikoo commented Dec 22, 2015 •
edited
Loading

Some places were already addressed:
d0fea73
4499d0f

Still, there is at least one vulnerability left:

    at Object.Deferred.resolve (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:123:15)
    at Function.exports._onresolve.then (/home/medikoo/ldz/2/node_modules/deferred/_ext.js:64:4)
    at Object.Deferred._settle (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:80:26)
    at Object.Deferred.resolve (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:123:15)
    at Function.exports._onresolve.then (/home/medikoo/ldz/2/node_modules/deferred/_ext.js:64:4)
    at Object.Deferred._settle (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:80:26)
    at Object.Deferred.resolve (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:123:15)
    at Object.DMap.processValue (/home/medikoo/ldz/2/node_modules/deferred/ext/array/map.js:78:49)
    at Function.exports._onresolve.done (/home/medikoo/ldz/2/node_modules/deferred/_ext.js:77:12)
    at Object.Deferred._settle (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:80:26)
    at Object.Deferred.resolve (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:123:15)
    at Object.DMap.processValue (/home/medikoo/ldz/2/node_modules/deferred/ext/array/map.js:78:49)
    at Function.exports._onresolve.done (/home/medikoo/ldz/2/node_modules/deferred/_ext.js:77:12)
    at Object.Deferred._settle (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:80:26)
    at Object.Deferred.resolve (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:123:15)
    at Function.exports._onresolve.then (/home/medikoo/ldz/2/node_modules/deferred/_ext.js:64:4)
    at Object.Deferred._settle (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:80:26)
    at Object.Deferred.resolve (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:123:15)
    at Function.exports._onresolve.then (/home/medikoo/ldz/2/node_modules/deferred/_ext.js:64:4)
    at Object.Deferred._settle (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:80:26)
    at Object.Deferred.resolve (/home/medikoo/ldz/2/node_modules/deferred/deferred.js:123:15)
@medikoo medikoo self-assigned this Dec 22, 2015
@medikoo
Copy link
Owner Author

medikoo commented Apr 8, 2016

Other one, which exposed today.

It looks as result of very long (1000+) then chain:

    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)
    at Function.exports._onresolve.then (/home/eregistrations/gt-production/node_modules/deferred/_ext.js:54:11)
    at Object.Deferred._settle (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:84:26)
    at Object.Deferred.resolve (/home/eregistrations/gt-production/node_modules/deferred/deferred.js:127:15)

@medikoo medikoo added the bug label Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@medikoo medikoo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@medikoo