Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the README whip example be using 'sendonly' tracks? #19

Open
cameronelliott opened this issue Oct 3, 2023 · 2 comments
Open

Comments

@cameronelliott
Copy link
Contributor

The readme example is currently:

//Send all tracks
for (const track of stream.getTracks()) {
	//You could add simulcast too here
	pc.addTrack(track);
}

But maybe it should be:

//Send all tracks
for (const track of stream.getTracks()) {
	//You could add simulcast too here
	pc.addTransceiver(track, { 'direction': 'sendonly' })
}

The RFC draft states 'SHOULD' for having sendonly transcievers.

Let me know if you want a PR

@murillo128
Copy link
Member

yes, that would be great

@murillo128
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants