Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Gift-cards detail component does not respect no division currencies #141

Closed
sebastiannicolajsen opened this issue Oct 13, 2021 · 2 comments
Closed

Gift-cards detail component does not respect no division currencies #141

sebastiannicolajsen opened this issue Oct 13, 2021 · 2 comments
Assignees
@geekusa33
Labels
type: bug Something isn't working type: good first issue Good for newcomers

Comments

@sebastiannicolajsen
Copy link
Contributor

Specifically, the formatNumber does the recalculation itself instead of using separate utility functions.
@sebastiannicolajsen sebastiannicolajsen added type: bug Something isn't working type: good first issue Good for newcomers labels Oct 13, 2021
@sebastiannicolajsen sebastiannicolajsen mentioned this issue Oct 13, 2021
Merged
@geekusa33
Copy link

Could I give this one a try?

@srindom
Copy link
Contributor

srindom commented Oct 15, 2021

@askalik Absolutely!

@geekusa33 geekusa33 mentioned this issue Oct 16, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@geekusa33 geekusa33

Labels
type: bug Something isn't working type: good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create formatNumber utility helper function
4 participants
@geekusa33 @srindom @olivermrbl @sebastiannicolajsen