Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do globs work in files? #34

Open
beyarkay opened this issue Jul 13, 2022 · 0 comments
Open

Do globs work in files? #34

beyarkay opened this issue Jul 13, 2022 · 0 comments

Comments

@beyarkay
Copy link

Hi!

Thanks for the project, really appreciate it.

Just wondering if globs work in files? for example will the following:

jobs:
  build:
  ...
    steps:
    ...
    - uses: meeDamian/github-release@v2.0.3
      with:
        token: ${{ secrets.GITHUB_TOKEN }}
        gzip: false
        allow_override: true
        files: build/*.txt

expand to upload every *.txt file under the build/ directory individually?

I've tried look through the source code, but my bash isn't as good as I thought. There's one comment that implies globbing does happen, but some small tests just in my shell make it seem like they don't work.

I think the following is the same as the source, but it doesn't glob, and echos calendars/*.ics

glob=build/*.txt
for filename in "$glob"; do
    echo $filename
done

However this example (which isn't the same) globs as expected:

for filename in build/*.txt; do
    echo $filename
done

If you can confirm what exactly the expected behaviour is, I'm happy to make a PR to add this feature!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant