This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat(highlight): implement hover highlight #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bugs I came across:
Besides that – really cool, thanks! |
marionebl
force-pushed
the
feat/preview-hover
branch
2 times, most recently
from
2a12a38
to
bc2b16e
Compare
|
I like this one! Some minor things: Hovering selected elementsWhen hovering a selected element in the tree view, the highlight area does not update but keeps the previously highlighted area: Screencast
Flash of highlighted elementsWhen deselecting all elements, all tree element receive the highlighted styling: Screencast
|
Palmaswell
force-pushed
the
feat/preview-hover
branch
from
daf346f
to
73a9c93
Compare
tilmx
changed the title
Palmaswell
force-pushed
the
feat/preview-hover
branch
3 times, most recently
from
0ce0357
to
ddbe8ab
Compare
tilmx
changed the title
|
Side note: We should not save everything when hovering @Palmaswell |
added 9 commits
June 1, 2018 00:52
marionebl
force-pushed
the
feat/preview-hover
branch
from
ddbe8ab
to
dc18029
Compare
marionebl
changed the title
Adressed via 8eb2d76 |
marionebl
approved these changes
May 31, 2018
markusoelhafen
pushed a commit
that referenced
this pull request
Jun 12, 2018
* refactor(highlight): implement tests for the hightlight component * refactor(highlight): hightlight area implementation * refactor(highlight): implement resize factory * fix(highlight): include hightlight update method * feat(highlight-hover): test implementation of the hightlight hover * feat(highlight): include eventhandler in store * feat(highlight): implementation of the highlight component * feat(highlight): highlight event handler * feat(highlight): finalize highlight component * perf: reduce highlight indicator state to id in preview
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.