This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: add description to property #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilmx
changed the title
tilmx
commented
May 31, 2018
| placeholder="…" | ||
| /> | ||
| </StyledContainer> | ||
| {description !== '' && <PropertyDescription description={description || ''} />} |
There was a problem hiding this comment.
The description is still shown as empty element – but I only want to show it when it is not ''. Can you help me with that @marionebl?
tilmx
changed the title
marionebl
previously approved these changes
May 31, 2018
| @@ -128,6 +128,7 @@ function createArrayProperty( | |||
| return { | |||
| contextId: args.symbol.name, | |||
| defaultValue: [], | |||
| description: args.symbol.name, | |||
There was a problem hiding this comment.
I think we should use an empty string here: ''
marionebl
approved these changes
May 31, 2018
markusoelhafen
pushed a commit
that referenced
this pull request
Jun 12, 2018
* feat: begin working on description inclusion * fixup! remove unneeded code * fixup! order alphabetically * fix: add descriptions to all property types * fix: set description as optional on enums * fix: properly read description in analyzer * fix: add styling for descriptions * fix: make ts happy * fix: render description only if it contains text * fix: remove unneeded descriptions * fix: set description to empty string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.