This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
fix: honor back/next state on page drops correctly #636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of bugs around page drag/drop.
Main change
DropState.next
vsDropState.back
if the Page should be inserted after (movePageAfter
) or before (movePageBefore
).Implementing the case handling exposed another bug where dropping/dragging a page on itself was not handled. I changed it to not show the drop indicators in this case.
Yak shaving
project.reArrangePagesIndex
, useproject.movePageTo
insteadproject.movePageAfter
toproject.movePageTo
to powerproject.movePageAfter
andproject.movePageBefore
getIndex
onPage
to avoid intermediary states inPageListContainer
. Only state inPageListContainer
now isdraggedPage
.