Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave and unpublish event not work for v1.3.0 #49

Closed
mDev86 opened this issue Dec 2, 2024 · 3 comments
Closed

Leave and unpublish event not work for v1.3.0 #49

mDev86 opened this issue Dec 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mDev86
Copy link
Contributor

mDev86 commented Dec 2, 2024

After update janus version to 1.3.0, leave and unpublish events stopped being called in videoroom.
Probably caused by meetecho/janus-gateway#3426. leave or unpublish not reached because display now is not undefined

изображение
@atoppi
Copy link
Member

atoppi commented Dec 2, 2024

Nice catch!
Can you try by moving the DISPLAY event parsing block after the LEAVING ?

@atoppi atoppi added the bug Something isn't working label Dec 2, 2024
@mDev86 mDev86 mentioned this issue Dec 2, 2024
Merged
@mDev86
Copy link
Contributor Author

mDev86 commented Dec 2, 2024

Yep, this working. Thanks.
Created PR #50

@atoppi
Copy link
Member

atoppi commented Dec 2, 2024

Thanks!
Fixed by #50.

@atoppi atoppi closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atoppi @mDev86