Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] missing SIP-Contact-header on SUBSCRIBE-messages #2973

Closed
doerner opened this issue May 10, 2022 · 6 comments
Closed

[1.x] missing SIP-Contact-header on SUBSCRIBE-messages #2973

doerner opened this issue May 10, 2022 · 6 comments
Labels
multistream Related to Janus 1.x

Comments

@doerner
Copy link

doerner commented May 10, 2022

What version of Janus is this happening on?
Janus 1.0.1-r0 on alpinelinux

Have you tested a more recent version of Janus too?
no

Was this working before?
no

Is there a gdb or libasan trace of the issue?
no

Additional context
SIP-SUBSCRUBE messages (using the sip-plugin) do not contain the mandatory Contact-header.

@doerner doerner added the multistream Related to Janus 1.x label May 10, 2022
@doerner doerner changed the title [1.x] [1.x] missing SIP-Contact-header on SUBSCRIBE-messages May 10, 2022
@lminiero
Copy link
Member

Sounds like something that should be fixed in Sofia SIP, if needed, not Janus, as we don't control the SIP logic. Please try a more recent version of Sofia SIP, if you have 1.2.11 installed, and reconfigure/recompile Janus.

@lminiero
Copy link
Member

@doerner did you have a chance to try a more recent version of Sofia SIP as suggested?

@doerner
Copy link
Author

doerner commented May 24, 2022

The alpine Linux distribution uses by standard a more recent Sofia SIP package (1.13.7). This is as far as I know the current version. (The quick fix I used so far is by modifying the Kamailio config file …)

@lminiero
Copy link
Member

Then I'm afraid there's nothing we can do about that. Setting the Contact header is up to the stack when you use NUA.

@lminiero
Copy link
Member

Just as a heads up, investigating issue #2974 I've found a fix for the missing contact header as well. I'll push a commit shortly that addresses both problems.

lminiero added a commit that referenced this issue May 26, 2022
…ugin when freeing a session while a subscription is active (2974)
lminiero added a commit that referenced this issue May 26, 2022
…ugin when freeing a session while a subscription is active (2974)
@lminiero
Copy link
Member

This should now be fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multistream Related to Janus 1.x
Projects
None yet
Development

No branches or pull requests

2 participants