Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for prettier as a JSON Formatter #421

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Add support for prettier as a JSON Formatter #421

merged 2 commits into from
Apr 19, 2021

Conversation

omusavi
Copy link
Contributor

@omusavi omusavi commented Apr 19, 2021

Adds JSON_PRETTIER formatter. Prettier is already being used for many other languages and formats such as YAML, and it supports JSON. Adding it here for consistency in JSON files.

Proposed Changes

  1. Added prettier to JSON descriptor
  2. Added some tests
  3. Ran build to generate docs

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@omusavi omusavi requested a review from nvuillam as a code owner April 19, 2021 19:19
@omusavi omusavi changed the title Json prettier Add support for prettier as a JSON Formatter Apr 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #421 (7b49f95) into master (4652b2b) will increase coverage by 1.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   86.62%   87.67%   +1.05%     
==========================================
  Files         123      124       +1     
  Lines        2915     2921       +6     
==========================================
+ Hits         2525     2561      +36     
+ Misses        390      360      -30     
Impacted Files Coverage Δ
...ests/test_megalinter/linters/json_prettier_test.py 100.00% <100.00%> (ø)
megalinter/MegaLinter.py 90.62% <0.00%> (+2.43%) ⬆️
megalinter/reporters/UpdatedSourcesReporter.py 89.18% <0.00%> (+2.70%) ⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py 99.12% <0.00%> (+9.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4652b2b...7b49f95. Read the comment docs.

@nvuillam nvuillam merged commit 881c4cb into oxsecurity:master Apr 19, 2021
@nvuillam
Copy link
Member

Nice idea, thanks a lot for your contribution :)

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants