Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aesthetic: Responsive Optimization - Transform Create Modal into full View #1067

Open
jaeko44 opened this issue Aug 24, 2016 · 7 comments
Open
Milestone

Comments

@jaeko44
Copy link
Contributor

jaeko44 commented Aug 24, 2016

In order to be able to optimize the create VM/app process for phones. I need a seperate view for devices under a certain width to use a full page view instead of a modal.

Meaning we don't popup a modal and instead redirect them to a Create VM page with the same inner contents as the modal.

This is because modals don't pair nicely with phones & are unnecessary.

@jaeko44
Copy link
Contributor Author

jaeko44 commented Aug 24, 2016

detectmob() { if( navigator.userAgent.match(/Android/i) || navigator.userAgent.match(/webOS/i) || navigator.userAgent.match(/iPhone/i) || navigator.userAgent.match(/iPad/i) || navigator.userAgent.match(/iPod/i) || navigator.userAgent.match(/BlackBerry/i) || navigator.userAgent.match(/Windows Phone/i) ){ return true; } else if (window.innerWidth <= 800 && window.innerHeight <= 600) { return true; } else { return false; } }

The above is a JS snippet I've previously used in a different project to detect if the user is using a phone.

@vinomca-megam
Copy link
Contributor

This is system based only.we will fix it in next release.

@vinomca-megam
Copy link
Contributor

What does you mean full page view? is it like separate page instead of Modal?

@jaeko44
Copy link
Contributor Author

jaeko44 commented Sep 2, 2016

Yes - but this is very low priority. Don't worry about it till after 1.5 release.

@rajthilakmca
Copy link
Member

@jaeko44 if we separate the create VM page instead of modal, then the maximum number of issues are closed, so could i replace it ?

@jaeko44
Copy link
Contributor Author

jaeko44 commented Sep 2, 2016

ok, we can replace using a modal till we fix the issues in the future. That is fine, we can use a full page.

@rajthilakmca
Copy link
Member

ok fine, i'll replace to page

@indykish indykish modified the milestones: 2.0, 1.5 Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants