Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about signed numbers #47

Open
raulpy271 opened this issue Feb 25, 2022 · 0 comments
Open

Add information about signed numbers #47

raulpy271 opened this issue Feb 25, 2022 · 0 comments

Comments

@raulpy271
Copy link

I was confused while reading the description of the opcode JR NZ, s8. Which is:

If the Z flag is 0, jump s8 steps from the current address stored in the program counter (PC). If not, the instruction following the current JP instruction is executed (as usual).

The description should say that the s8 argument is a signed number, which are encoded in two's complement. This is a usefull information that is missing in the description.

Do you agree?

Besides, this table in helping me a lot in my journey creating a emulator, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant