Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

megadesignassets submodule is inaccessible #1010

Closed
KottV opened this issue Oct 29, 2024 · 3 comments
Closed

megadesignassets submodule is inaccessible #1010

KottV opened this issue Oct 29, 2024 · 3 comments

Comments

@KottV
Copy link

KottV commented Oct 29, 2024

Hi,

If I try to clone the source recursively or update submodules, then this path (git@code.developers.mega.co.nz:megadesignassets/megadesignassets.git) seems has restricted access:
ssh: connect to host code.developers.mega.co.nz port 22: Connection timed out

Not sure if it's required, as there is ENABLE_DESIGN_TOKENS_IMPORTER option, but it breaks automated builds which pull the source from GH.

@vtmateos
Copy link
Member

Hi,
The megadesignassets repository is an internal repository that contains various design tokens for the application. The Design token importer serves as a parser tool to generate artifacts and assets used during the application's build process using those designs.

We have two options: either disable it as a submodule and hide the tool (it's not necessary) or publish the megadesignassets repository on GitHub and update the paths in the .gitmodules file accordingly.

Meanwhile, you can discard that error and switch ENABLE_DESIGN_TOKENS_IMPORTER to OFF in CMake file. Try again and let us know how the process goes.

Thanks.

@KottV
Copy link
Author

KottV commented Dec 1, 2024

Maybe it's possible to put this dependency inside the cmake? So, if it's enable the pull and use (with fetchcontent or git directly or any).

Meanwhile, you can discard that error and switch ENABLE_DESIGN_TOKENS_IMPORTER to OFF in CMake file. Try again and let us know how the process goes.

Yes, I do exactly this. But the problem is that I can't do simple git clone --recursively in the build script, I have to separately grab the mega_sdk then.

@vtmateos
Copy link
Member

vtmateos commented Dec 4, 2024

Thanks for the suggestion. You're right we will clone on demand if the DESIGN-TOKENS cmake option is enabled.
We will add it on a next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants