This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
lodash-fp support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var mapper = _lodashFp.map(_lodashFp.add(1)); | ||
| var result = mapper([1, 2, 3]); | ||
| _lodashFp.take(1, _lodashFp.reject(Boolean, result)); |
There was a problem hiding this comment.
If you get a second @jdalton mind sanity checking this output. It seems correct to me.
There was a problem hiding this comment.
The fp part? It looks good.
This is so crazy cool.
megawac
force-pushed
the
lodash-fp
branch
2 times, most recently
from
91c294b to
dadf7ee
Compare
|
|
||
| var _lodashFpConvert2 = _interopRequireDefault(_lodashFpConvert); | ||
|
|
||
| var _lodashFp = (0, _lodashFpConvert2['default'])({ |
There was a problem hiding this comment.
Why the 0 in (0, _lodashFpConvert2['default']) ?
There was a problem hiding this comment.
It's something babel adds when interacting with default imports, I'm not entirely sure why
There was a problem hiding this comment.
maybe in case it's an eval so it would be an indirect eval?
Cleanup fp variables
|
Awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.