Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for Generic Dataset #54

Open
bjfultn opened this issue Feb 25, 2019 · 2 comments
Open

Example for Generic Dataset #54

bjfultn opened this issue Feb 25, 2019 · 2 comments

Comments

@bjfultn
Copy link
Contributor

bjfultn commented Feb 25, 2019

Is it feasible to create an example of setting up the appropriate hd5 dataset with a more generic set of input spectra files? This might be as simple as documenting the make_data.write_data function in great detail in a tutorial on the RTD page. Some specific questions I have are after briefly looking through the make_data.py script.

  • What data is actually needed from the HARPS files (without having to look up what the HARPS header keywords mean)?
  • Are there any pieces of the data that are optional?
@megbedell
Copy link
Owner

For the moment I've added a long docstring to make_data.write_data to specify what things are & which ones are optional. Not an ideal solution but hopefully it helps!

@bjfultn
Copy link
Contributor Author

bjfultn commented Feb 26, 2019

This is a great help, thanks! If you could add the documentation for that function into the API docs on the RTD page then I think we can close or greatly lower the priority of this issue. Maybe move that function into wobble.utils or wobble.data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants