Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borders on tall grounds aren't properly drawn #1031

Open
2 of 5 tasks
nekiro opened this issue Jan 9, 2025 · 3 comments
Open
2 of 5 tasks

Borders on tall grounds aren't properly drawn #1031

nekiro opened this issue Jan 9, 2025 · 3 comments
Labels
bug Something isn't working Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@nekiro
Copy link
Collaborator

nekiro commented Jan 9, 2025 •
edited
Loading

Priority

Medium

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

By fixing the borders I introduced another bug with tall grounds and borders. They are simply not drawn at all.

Example:
#1014 (comment)

I'm not sure how to fix this.
Cipsoft also doesnt draw big carpets properly, but I guess we can be better than them :D

What OS are you seeing the problem on?

Linux, Windows, MacOS

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nekiro nekiro added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 9, 2025
@nekiro nekiro changed the title borders on tall grounds aren't properly drawn Borders on tall grounds aren't properly drawn Jan 9, 2025
@github-actions github-actions bot added bug Something isn't working Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Jan 9, 2025
@mehah
Copy link
Owner

mehah commented Jan 9, 2025

I've reverted your fix for now, until we can think of a better solution.
10d1216

@nekiro
Copy link
Collaborator Author

nekiro commented Jan 9, 2025 •
edited
Loading

I've reverted your fix for now, until we can think of a better solution. 10d1216

Imo it wasn't necessary, carpets are more important than some cosmetics on mountains xD
But I guess let's keep cipsoft behaviour.

@mehah
Copy link
Owner

mehah commented Jan 9, 2025

@nekiro
Regarding the carpets , it wouldn't be better as an item, cip declares carpets as a common item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mehah @nekiro