Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player diagonal direction lag #469

Closed
2 of 5 tasks
Riverlance opened this issue Mar 12, 2023 · 2 comments
Closed
2 of 5 tasks

Player diagonal direction lag #469

Riverlance opened this issue Mar 12, 2023 · 2 comments
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Riverlance
Copy link
Contributor

Riverlance commented Mar 12, 2023

Priority

Medium

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

89172a5ae0907fbbc5f9e84bcdccfd49

How to reproduce

  1. Walk in diagonal using your keyboard (numpad 7/9/1/3 numbers with numlock disabled).
  2. Click to walk anywhere with your mouse.

Note: I tried this with the original code of 12th March 2023 with original TFS 1.5.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Riverlance Riverlance added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Mar 12, 2023
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Mar 12, 2023
@poxis
Copy link
Collaborator

poxis commented Mar 12, 2023

try #401 but in my case it did not help....

@poxis
Copy link
Collaborator

poxis commented Mar 14, 2023

hmm i found fix bug "walk on one sqm' work for me..

void Creature::updateWalk(const bool isPreWalking)

change:

    if (!isPreWalking && m_walkedPixels == SPRITE_SIZE) {
        terminateWalk();
    }

to:

   if (m_walkedPixels == SPRITE_SIZE) {
        if (!isPreWalking)
             terminateWalk();
        else
            m_walkAnimationPhase = 0;
    }

@mehah mehah closed this as completed in 900c7cb Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

2 participants