-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add Forms Support #23
Comments
Since current input components return actual data as the first argument, this might need to be changed to work with react-form-hooks as it expects the |
I'd recommend taking a look at our forms guide in React Aria: https://react-spectrum.adobe.com/react-aria/forms.html. In many cases you don't even need react-hook-form or zod because the builtin validations are enough. There is a section about using those libraries, but I'd recommend starting simple and only adding them if needed. React Aria Components supports constraint validation, custom validation functions, server validation, etc. It's best to do zod-style validations on the server for security, and you can send the errors back to display via React Aria as well. |
I see. Here are my thoughts about the way I proposed,
The React Aria approach and shadcn/ui approach both do it well but its lot of repetitive codes in each input. Let me know about your thoughts |
Feature description
Overview
I would love to add Forms support to this library with the clean declarative approach inspired by Ant Design with the use of react-hook-form and Zod as the validation library.
Benefits
What the developer has to do is structure the form and give the zod schema, the
<Form.Item>
will handle all the validation internally, andonFinish
only calls when the form is validated.Proposed Structure
Affected component/components
All Input fields
Additional Context
No response
Before submitting
The text was updated successfully, but these errors were encountered: