Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Load calibration" followed by "Capture Background" gives error #180

Closed
talonchandler opened this issue Sep 16, 2022 · 2 comments · Fixed by #184
Closed

[BUG] "Load calibration" followed by "Capture Background" gives error #180

talonchandler opened this issue Sep 16, 2022 · 2 comments · Fixed by #184
Assignees
Labels
bug Something isn't working
Milestone

Comments

@talonchandler
Copy link
Collaborator

"Load calibration" followed by "Capture Background" yields:
Error: unsupported operand type(s) for *: 'NoneType' and 'float'

@talonchandler talonchandler self-assigned this Sep 16, 2022
@talonchandler talonchandler added this to the 0.2.0 milestone Sep 16, 2022
@talonchandler
Copy link
Collaborator Author

It seems like the lca{a/b}_{0,60,120} attributes of QLIPP_Calibration are not being set correctly during "Load calibration".

Ziwen, would you mind helping out with this? I think you should be able to recreate this issue locally.

@ziw-liu ziw-liu added the bug Something isn't working label Sep 19, 2022
@talonchandler
Copy link
Collaborator Author

I think the return is used, but in a sneaky way by self.worker.returned here:

https://github.com/mehta-lab/recOrder/blob/main/recOrder/plugin/widget/main_widget.py#L2460

It seems like the calibration must be returned somehow, or else the LCs wouldn't receive any of the data from the thread.

This page was pretty helpful for me to understand how this section works:
https://napari.org/stable/guides/threading.html

"The @thread_worker decorator converts your function into one that returns a WorkerBase instance."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants