Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.0's offline mode has dropped support for mixed-channel reconstructions #230

Closed
talonchandler opened this issue Oct 12, 2022 · 0 comments · Fixed by #249
Closed

0.2.0's offline mode has dropped support for mixed-channel reconstructions #230

talonchandler opened this issue Oct 12, 2022 · 0 comments · Fixed by #249
Assignees
Milestone

Comments

@talonchandler
Copy link
Collaborator

On Friday afternoon @Soorya19Pradeep and I installed recOrder==0.2.0 on hummingbird and found that the removal of the fluorescence features from recOrder also removed support for reconstructions when some channels are polarization channels and other channels are fluorescence channels. This regression was unintended and I take responsibility.

@mattersoflight, @ieivanov, @ziw-liu, and @edyoshikun discussed our plan yesterday, and we decided that we will remove the undertested and buggy offline mode from recOrder for our 0.3.0 release and migrate our current offline mode users to waveorder scripts where we've been performing mixed-channel reconstructions regularly.

@Soorya19Pradeep I will support your transition to waveorder scripts.

@talonchandler talonchandler self-assigned this Oct 12, 2022
@talonchandler talonchandler added this to the 0.3.0 milestone Oct 12, 2022
@talonchandler talonchandler linked a pull request Nov 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant