Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate fluorescence reconstructions to torch and model-based structure #122

Open
talonchandler opened this issue Jun 8, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@talonchandler
Copy link
Collaborator

I'm planning to move the fluorescence reconstructions to torch and to the new model-based structure.

  • the waveorder_reconstructor/fluorescence_microscopy class will eventually be deprecated
  • the current fluorescence_microscopy class supports 2D, 3D, and fluorescence anisotropy reconstructions. Following our <sample_type>_<sample_thickness>_<data_type> model-name schema, I will suggest moving+renaming these reconstructions to:
  1. 2D -> isotropic_fluorescent_thin_3d
  2. 3D -> isotropic_fluorescent_thick_3d
  3. fluorescence anisotropy -> inplane_anisotropic_fluorescent_thin_pol3d

@mattersoflight naming discussion is welcome.

@mattersoflight @edyoshikun if our immediate needs require just the isotropic_fluorescent_thick_3d, then I will prioritize that model.

@mattersoflight
Copy link
Member

mattersoflight commented Jun 12, 2023

@talonchandler Here is my reading of inputs and outputs, and suggestions for naming conventions:

2D -> isotropic_fluorescent_thin_3d: 3D input is a short z-stack (say 5 slices covering the DOF) and output is the restored fluorescence at the plane of focus using defocused OTFs. Analogous to isotropic_phase_thin_3D.
3D -> isotropic_fluorescent_thick_3d: 3D deconvolution.

We should also add isotropic_fluorescent_thin_2D, which would be a simple 2D deconvolution with 2D OTF.

The most basic (geometric) model for fluorescence anisotropy Fluor_anisotropy_recon may be named inplane_orientation_fluorescent_thick_pol3d. The input is a 3D polarization-resolved stack and the output are 3D as well. I am suggesting orientation over the word fluorescence anisotropy because anisotropy signifies rotational diffusion to many.

@mattersoflight
Copy link
Member

Yes, isotropic_fluorescent_thick_3d is immediately useful - please prioritize that while keeping in mind the overall dependencies between different models.

@talonchandler
Copy link
Collaborator Author

Great, I like these suggestions a lot.

isotropic_fluorescent_thick_3d is the highest priority, and the following three can follow later:

isotropic_fluorescent_thin_3d
isotropic_fluorescent_thin_2d
inplane_oriented_fluorescent_thick_pol3d

@talonchandler
Copy link
Collaborator Author

The highest-priority fluorescence reconstruction isotropic_fluorescent_thick_3d was migrated to torch in #128.

I'm collecting the remaining migrations into a list here:

  • isotropic_fluorescent_thin_3d
  • isotropic_fluorescent_thin_2d
  • inplane_oriented_fluorescent_thick_pol3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants