Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review code sample changes #3025

Open
guimachiavelli opened this issue Oct 10, 2024 · 4 comments
Open

Review code sample changes #3025

guimachiavelli opened this issue Oct 10, 2024 · 4 comments

Comments

@guimachiavelli
Copy link
Member

We have not been very good at keeping track of code sample updates outside of those related to new versions. This might have lead to a mismatch between curl and SDK examples.

We need to compile a list of all PRs that touched the code samples file since July 2023, then notify @meilisearch/integration-team.

@curquiza
Copy link
Member

(Not an emergency of course, but useful at some point)

@brunoocasali
Copy link
Member

We used to have a script that Charlotte created, but after the migration of the website, we kind of lost it :(
Probably could be a good time to create a new one instead of checking one by one 👯

@curquiza
Copy link
Member

curquiza commented Oct 16, 2024

@brunoocasali we still have a script (not sure this is the one Charlotte created) but I used it less than a year ago: https://github.com/meilisearch/integration-automations/tree/main/code-samples-checkers

But the script can only say about the MISSING code samples, not the ones that have been updated

@guimachiavelli
Copy link
Member Author

As a quick update to this, @curquiza and I will try to create a GH automation that will automatically add PRs that touch the code samples file to a project. This should make it easier to keep track of changes moving forward. That doesn't help us with past changes, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants