Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.10.0] Add CONTAINS operator #393

Open
1 task
brunoocasali opened this issue Aug 27, 2024 · 5 comments
Open
1 task

[v1.10.0] Add CONTAINS operator #393

brunoocasali opened this issue Aug 27, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

Following this central issue

Explanation of the feature

Usage: https://github.com/orgs/meilisearch/discussions/763

New operator CONTAINS when using filter

TODO

  • Add a new parameter to the dart DSL
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Aug 27, 2024
@curquiza
Copy link
Member

@brunoocasali, why this issue? It seems we pass string to "filter", and not something built, but I might be wrong:

await index.search('prince', SearchQuery(filter: '"tag" = Tale'));

@ahmednfwela if you have the answer 😇

@ahmednfwela
Copy link
Collaborator

we have our own classes to map meilisearch operators, which are statically typed, and handle escaping
@curquiza

@ahmednfwela
Copy link
Collaborator

see here for example:

await client.index('movie_ratings').search(

@curquiza
Copy link
Member

Ok.... I have to say it seems very complicated for something we could have handled with strings only 🙈

@ahmednfwela
Copy link
Collaborator

well, the user can still use strings if they want, but having static typing for queries is definitely a good option

for example some users might mistakenly convert date time to iso string format, but we use epoch time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants