Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to delete the index only if it already exists #231

Closed
2 tasks
curquiza opened this issue Oct 6, 2021 · 7 comments · Fixed by #248
Closed
2 tasks

Add a method to delete the index only if it already exists #231

curquiza opened this issue Oct 6, 2021 · 7 comments · Fixed by #248
Labels
good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

curquiza commented Oct 6, 2021

Trying to delete an index that does not exist on the MeiliSearch server will throw an error. To delete it without any error no matter what if it exists or not, we need a new method.

  • Add a method delete_index_if_exists: it deletes the index but does not throw any error if the index does not exist.
  • Add tests

Example: https://github.com/meilisearch/meilisearch-python/pull/268/files

⚠️ This issue is generated, and delete_index_if_exists might be named differently in this package. Keep the already existing way of naming in this package to stay idomatic with the language and the repository.

Related to meilisearch/integration-guides#107

Sorry if this is already partially/completely implemented, feel free to let me know about the state of this issue.

@bkaur-bkj
Copy link

@curquiza pls let me know about the status of this issue if any changes? if still pending can you pls assign this issue to me

@alallema
Copy link
Contributor

alallema commented Oct 6, 2021

Hi @bkaur-bkj,
This issue is still open. I assigned you on it! :)

@bkaur-bkj
Copy link

My ide is showing some issues with configuration so unassigning it for now

@bkaur-bkj bkaur-bkj removed their assignment Oct 8, 2021
@alallema
Copy link
Contributor

alallema commented Oct 8, 2021

Thanks for telling us.

@adrianrojek
Copy link

Hello, is this issue still open ? I'd like to help, could you assign it to me please?

@alallema
Copy link
Contributor

alallema commented Oct 8, 2021

Hi @adrianrojek,
Yes this PR is still open.
We don't want to assign people to our issues because sometimes people ask to be assigned and never come back, which discourages the real volunteers contributors to open a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.

@ezienecker
Copy link
Contributor

I provide a PR: #248

@curquiza curquiza linked a pull request Oct 16, 2021 that will close this issue
@bors bors bot closed this as completed in #248 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants