-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the error handling are following the best practice #1565
Comments
MeilisearchError class MeilisearchError extends Error { |
Hey , Can I Solve these issues |
Yes, just submit your PR with the fix :) |
is this issue still open for fix? |
Hello @Faizan711 Thanks for your interest in this project 🔥 You are definitely more than welcome to open a PR for this! For your information, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors from opening a PR to fix this issue. We are looking forward to reviewing your PR 😊 |
Oh, thats great |
Also, if you are a maintainer, please add any clarification and instructions about this issue.
Sorry if this is already wholly/partially implemented. Feel free to let me know about the state of this issue in the repo.
Related to meilisearch/integration-guides#267
Ensure this SDK follows the following guidelines:
MeilisearchCommunicationError
MeilisearchApiError
MeilisearchError
Essentially all the error should extend from
MeilisearchError
, the consumers should have a way to catch all the errors.Let us know if this is not clear, or you have better idea!
TODO:
MeilisearchError
which will extend the standard error if it does not exist (when the language supports)MeilisearchCommunicationError
since it is not a Meilisearch error anyway.The text was updated successfully, but these errors were encountered: