-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to ESM from CommonJS #1626
Comments
Okay, I might go a little overboard with this one. For all of this to be as good as it can possibly be, it was best for me to move the project to I chose Vitest, quite popular and Jest compatible. Also Since I need to know if we really want to support Internet Explorer 11, so I know what version of ES to bundle the UMD to. |
This was very confusing for me. The files contained a path to the dist UMD bundle, didn't realize at first that they're supposed to be hard links. Now that I know what they are, I could fix them. But it is very much not recommended to have these things in your codebase. http://tdongsi.github.io/blog/2016/02/20/symlinks-in-git/ |
I would like to add that any change that might come from this issue or others that change the configurations for the better is very welcomed, but they should work with our existing playgrounds. Example: Due to the change made here we introduced an extra step to the end user when they are using Vue3 on Vite (possibly all vite envs). |
Yeah, sorry about that, I should've tested the playgrounds as well. I'm not sure why it worked beforehand, I need to investigate further. But I have plans that addresses this as well, the way the code is split up for Node.js and browsers is not ideal, and can cause surprises like the one you mentioned. |
Yeah, that would be awesome if we could improve that and avoid those issues in the future, I'm looking forward to see it! |
To modernize the project, we should move from CommonJS to ESM, and update/switch bundler. This also requires changes to TypeScript configuration. Since Jest isn't fully ESM compatible as noted here at the time of writing, we should move to Vitest.
The text was updated successfully, but these errors were encountered: