Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.10.0] Language settings & search parameter #1684

Closed
4 tasks done
curquiza opened this issue Jul 29, 2024 · 1 comment · Fixed by #1693
Closed
4 tasks done

[v1.10.0] Language settings & search parameter #1684

curquiza opened this issue Jul 29, 2024 · 1 comment · Fixed by #1693
Assignees
@flevi29
Labels
enhancement New feature or request good first issue Good for newcomers Meilisearch bump Changes related to the Meilisearch bump version

Comments

@curquiza
Copy link
Member

curquiza commented Jul 29, 2024 •
edited by flevi29
Loading

Related to meilisearch/integration-guides#302

Explanation of the feature

Changes

  • new settings localizedAttributes and the sub-methods associated to it
  • new search parameter locales

Usage: https://meilisearch.notion.site/v1-10-Language-settings-usage-26c5d98b553349d9abacbe7aff698e4e

TODO

  • Add a new search parameter named locales to the search methods (GET and POST)
  • Ensure the updateSettings route can accept the new localizedAttributes setting
  • Create new methods getLocalizedAttributes, updateLocalizedAttributes and resetLocalizedAttributes corresponding to the sub settings GET/PUT/DELETE routes
  • Add tests

⚠️ Make PRs pointing to bump-meilisearch-v1.10.0 and NOT main. Please do 1 PR for all of these changes, and not several.
@curquiza curquiza added enhancement New feature or request good first issue Good for newcomers Meilisearch bump Changes related to the Meilisearch bump version labels Jul 29, 2024
@curquiza curquiza mentioned this issue Jul 29, 2024
Closed
30 tasks
@flevi29 flevi29 self-assigned this Aug 19, 2024
@flevi29 flevi29 mentioned this issue Aug 20, 2024
Merged
3 tasks
@flevi29 flevi29 linked a pull request Aug 20, 2024 that will close this issue
Add language settings & search parameter #1693
Merged
3 tasks
@curquiza
Copy link
Member Author

Closed by #1693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flevi29 flevi29

Labels
enhancement New feature or request good first issue Good for newcomers Meilisearch bump Changes related to the Meilisearch bump version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add language settings & search parameter flevi29/meilisearch-js
2 participants
@curquiza @flevi29