Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to delete the index only if it already exists #224

Closed
2 tasks
curquiza opened this issue Oct 6, 2021 · 2 comments · Fixed by #226
Closed
2 tasks

Add a method to delete the index only if it already exists #224

curquiza opened this issue Oct 6, 2021 · 2 comments · Fixed by #226
Labels
good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

curquiza commented Oct 6, 2021

Trying to delete an index that does not exist on the MeiliSearch server will throw an error. To delete it without any error no matter what if it exists or not, we need a new method.

  • Add a method delete_index_if_exists: it deletes the index but does not throw any error if the index does not exist.
  • Add tests

Example: https://github.com/meilisearch/meilisearch-python/pull/268/files

⚠️ This issue is generated, and delete_index_if_exists might be named differently in this package. Keep the already existing way of naming in this package to stay idomatic with the language and the repository.

Related to meilisearch/integration-guides#107

Sorry if this is already partially/completely implemented, feel free to let me know about the state of this issue.

@bofalke
Copy link
Contributor

bofalke commented Oct 6, 2021

Hi, this sounds interesting, i would like to help out here

@alallema
Copy link
Contributor

alallema commented Oct 6, 2021

Hi @bofalke,
I can assigned you if you wish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants