Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all the attributes on SearchQuery #547

Closed
brunoocasali opened this issue Jul 11, 2023 · 1 comment
Closed

Refactor all the attributes on SearchQuery #547

brunoocasali opened this issue Jul 11, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

Move all the private attributes to be optional and null by default. This will allow removing the null coalescing ?? null from the toArray() call.

As pointed out here: #543 (review)
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Jul 11, 2023
@brunoocasali brunoocasali mentioned this issue Jul 11, 2023
Merged
@norkunas
Copy link
Collaborator

Looks like I missed to reference this in #684 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@norkunas @brunoocasali