Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline consistency in code-samples #327

Closed
bidoubiwa opened this issue Aug 30, 2022 · 0 comments · Fixed by #331
Closed

Newline consistency in code-samples #327

bidoubiwa opened this issue Aug 30, 2022 · 0 comments · Fixed by #331
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Aug 30, 2022

In the .code-samples.meilisearch.yaml file some samples are one-liners and some are split in newlines.

We would like to create consistency between these examples.

Because newline is more easy to read, the idea is to change every one liner in a multiple line command.

For example:

let task: TaskInfo = client.index("jackets").set_distinct_attribute("product_id").await.unwrap();

Becomes

let task: TaskInfo = client
            .index("jackets")
            .set_distinct_attribute("product_id")
            .await
            .unwrap();

⚠️ DO not work on this before this PR is merged #297

@bidoubiwa bidoubiwa added the good first issue Good for newcomers label Aug 30, 2022
@bidoubiwa bidoubiwa added the documentation Improvements or additions to documentation label Aug 31, 2022
@bors bors bot closed this as completed in 261fa52 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant