-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slowness during the display #167
Comments
Checked with @bidoubiwa, some additional information that might interest the mini-dashboard:
However, these both points do not explain why there is a difference in latency between instant-meilisearch alone and the mini dashboard, unfortunately (cf videos in the issue description) |
Hey @entrptaher, I see a |
Hey @bidoubiwa 👋 Using the |
The requests are fast, but when they render 1300 items, it gets slow. :( |
I think the solution to that would be to lazyload the index list See example and more information here |
I would like to do this. |
Feel free to do so @vaibhav135 :) Thanks 🙏 We prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the real volunteers contributors from opening a PR to fix this issue. |
@bidoubiwa a quick update on this one. I am almost done with it. I am using react-window with react-select. Just need to do little style change and I will be done. Btw I want to know if testing it with 1300 (datasets) is enough or I should go for more. |
Hey @vaibhav135 Since this PR is very old, I'm not sure this is still an issue. In your PR, could you see a big difference in processing time? |
@bidoubiwa Yes definitely, I would say when you have like 1000 or more datasets loaded. The current dropdown is barely usable and super slow. I will attach the before and after once I am done. |
Nice! Thanks a lot :) If you already see some significant improvements, you don't need to test with more. If you still would like to, you can use this one https://github.com/meilisearch/datasets/tree/main/datasets/movies |
Hey @vaibhav135 thanks, indeed it's way faster :) |
As it was reported on our Slack community, some slowness is noticeable using the mini-dashboard.
This slowness is not present when only using instant-meilisearch (the dependency used by this repo).
As you can see:
Mini-dashboard:
https://user-images.githubusercontent.com/20380692/139108096-d4e8d7fc-03f8-4157-adc6-11697c02f239.mp4
Only instant-meilisearch
https://user-images.githubusercontent.com/20380692/139108334-2cd7f9fd-a200-46a2-a618-ced5a453a086.mp4
Also here are the processing time of Instant MeiliSearch
Can interest @bidoubiwa
Ask for @bidoubiwa for the dataset
The text was updated successfully, but these errors were encountered: